[4.2] PHP8.2 Remove the not used method assignment in mm API#39612
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Jan 14, 2023
Merged
[4.2] PHP8.2 Remove the not used method assignment in mm API#39612roland-d merged 2 commits intojoomla:4.2-devfrom
roland-d merged 2 commits intojoomla:4.2-devfrom
Conversation
Member
|
@laoneo still the data not loading. But also is giving a js error Uncaught SyntaxError: Unexpected token '<', "<br />
<b>"... is not valid JSON
at JSON.parse (<anonymous>)
at onSuccess (media-manager.js?c9d04fea6dae2c821fd73c99da6c9835:8113:45)
at xhr.onreadystatechange (core.js?c9d04fea6dae2c821fd73c99da6c9835:669:23)[with 8.2 only] |
Member
Author
|
In the browser tools can you inspect the XHR request, what for a error message is displayed in the response? |
Member
|
Sorry, forgot that:
|
Member
|
But I confirm the error of the not used method variable and the patch fix it. The other error is not relate with this one |
Member
|
I have tested this item ✅ successfully on d0c53b7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on d0c53b7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39612. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes the not used method variable in the media manager APIController.
Testing Instructions
Open the media manager on PHP 8.2
Actual result BEFORE applying this Pull Request
Media data is not loaded.
Expected result AFTER applying this Pull Request
Media data is loaded.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed