[4.2] content history alerts#39611
Merged
roland-d merged 3 commits intojoomla:4.2-devfrom Jan 12, 2023
Merged
Conversation
Converts from the ugly browser dependent alerts to use the joomla rendermessage ## To test run npm build:js or use a prebuilt package Create and save an article and then edit it and save again Click on Versions Click on all versions and then preview ### before ### after Click on all versions and then restore ### before ### after Click on one version and then compare
Contributor
|
I have tested this item ✅ successfully on 124d167 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39611. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 124d167 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39611. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39611. |
Contributor
|
Thank you |
Contributor
Author
|
thanks for the quick tests and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts from the ugly browser dependent alerts to use the joomla rendermessage
To test
run npm build:js or use a prebuilt package
Create and save an article and then edit it and save again Click on Versions
Click on all versions and then preview
Click on all versions and then restore
Click on one version and then compare
before - ugly alerts
after - joomla less ugly
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed