[RFC] Fix subform multiple tinymce elements alternative#39609
Closed
dgrammatiko wants to merge 4 commits intojoomla:4.2-devfrom
Closed
[RFC] Fix subform multiple tinymce elements alternative#39609dgrammatiko wants to merge 4 commits intojoomla:4.2-devfrom
dgrammatiko wants to merge 4 commits intojoomla:4.2-devfrom
Conversation
5ff326a to
34ae6ad
Compare
34ae6ad to
6e320f7
Compare
Member
|
hou hou hou 🎅 |
Contributor
Author
|
I mean I can add some events to let devs fill the dialog and remove the eval parts (I didn't introduce them now, they existed). Anyways I though I will give it a try |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request is an alternative to #39449 which is for Issue #39416 .
Summary of Changes
editorid both for click action and for the modals callback, etcTesting Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Screen.Recording.2023-01-11.at.22.25.17.mov
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@wilsonge @Fedik what do you think?