Skip to content

[4.2] PHP8.2 Add the missing props to the password form field#39608

Merged
HLeithner merged 3 commits intojoomla:4.2-devfrom
Digital-Peak:php82/field/password
Jan 12, 2023
Merged

[4.2] PHP8.2 Add the missing props to the password form field#39608
HLeithner merged 3 commits intojoomla:4.2-devfrom
Digital-Peak:php82/field/password

Conversation

@laoneo
Copy link
Copy Markdown
Member

@laoneo laoneo commented Jan 11, 2023

Summary of Changes

Define the missing properties in the PasswordField class to prevent deprecation notice on PHP 8.2.

Test by code review.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Jan 11, 2023
@joomdonation
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on a1c61c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39608.

1 similar comment
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jan 12, 2023

I have tested this item ✅ successfully on a1c61c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39608.

@joomdonation
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39608.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@HLeithner HLeithner merged commit bc6a5f3 into joomla:4.2-dev Jan 12, 2023
@HLeithner
Copy link
Copy Markdown
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@laoneo laoneo deleted the php82/field/password branch January 12, 2023 16:17
@Quy Quy added this to the Joomla! 4.2.7 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants