[4.2] PHP8.2 Add the missing props to the calendar form field#39605
Merged
HLeithner merged 2 commits intojoomla:4.2-devfrom Jan 12, 2023
Merged
[4.2] PHP8.2 Add the missing props to the calendar form field#39605HLeithner merged 2 commits intojoomla:4.2-devfrom
HLeithner merged 2 commits intojoomla:4.2-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 75bf44b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39605. |
Contributor
|
I have tested this item ✅ successfully on 75bf44b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39605. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39605. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Define the missing properties in the CalendarField class to prevent deprecation notice on PHP 8.2.
Testing Instructions
Open the Publishing tab in the article form on PHP 8.2 on the back end with debug enabled.
Actual result BEFORE applying this Pull Request
The following warning is shown:
Creation of dynamic property Joomla\CMS\Form\Field\CalendarField::$todaybutton is deprecated inExpected result AFTER applying this Pull Request
No warning.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed