[4.2] PHP8.2 Define the threshold in cache#39604
Merged
HLeithner merged 4 commits intojoomla:4.2-devfrom Jan 12, 2023
Merged
Conversation
Contributor
|
OK now but there is no Test this button in issue tracker to report test result for some reasons. |
Member
|
@laoneo this deprecation notice also show in the articles view |
Member
Author
|
I know, it is almost on every page where the cache is used. @carlitorweb did you test it successfully? Then I would set it to RTC as well as @joomdonation couldn't mark his result in the tracker. |
Member
|
Me either @laoneo , the button not was there. |
Member
Author
|
Setting RTC as we have two tests. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39604. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Define the threshold property in the CacheStorage class to prevent deprecation notice on PHP 8.2.
This must be tested by code review as it only happens when I want to install the DPCalendar sample data. But it is pretty obvious.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed