I have tested this item ✅ successfully on 1c8a2c3

code review

Shouldn't we add the missing properties instead? By scanning the code, there are two missing properties:

• clientIP https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Log/Logger/FormattedtextLogger.php#L190
• datetime https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Log/Logger/FormattedtextLogger.php#L197

should be enough based on https://php.watch/versions/8.2/AllowDynamicProperties

First I did this, then I came to the conclusion that, every formater can add it's own custom properties. That's why I made it that way. The text logger is a good example. It adds specific properties which are only used by that specific logger. Others can do the same. That's why the LogClass should allow dynamic properties.

should be enough based on https://php.watch/versions/8.2/AllowDynamicProperties

Enough for not but will result on fatal error on PHP 9. I think we should take this chance to fix the code properly instead of hiding the warnings for now and suddenly seeing fatal when PHP 9 releases.

then I came to the conclusion that, every formatter can add it's own custom properties

Hard to discuss without seeing the real code. If we really have to allow define dynamic property like that, maybe make the class LogEntry extends \stdClass could be an option. I will leave this to someone else to decide.

The AllowDynamicProperties attribute should also work in PHP 9. There is no indication in the RFC, that this attribute will not work.

Base on various sources I read , it will be fatal error on PHP 9:

• https://php.watch/versions/8.2/dynamic-properties-deprecated

The deprecation notice is emitted on PHP 8.2 and later. In PHP 9.0, dynamic properties will result in a fatal error.

• https://stitcher.io/blog/deprecated-dynamic-properties-in-php-82

And remember that it won't be a fatal error until PHP 9.0, so there's plenty of time to deal with it

That's reason I want to add missing properties when it's possible instead of using AllowDynamicProperties

It will be a fatal error only when the AllowDynamicProperties attribute is not there.

It will be a fatal error only when the AllowDynamicProperties attribute is not there

Ah, OK. Read the RFC again, I can confirm that. Thanks !

I like the approch of make the class LogEntry extends \stdClass. In my opinion this is a more stable solution than add the attribute

I have tested this item ✅ successfully on 1c8a2c3

RTC

I think that's a bad idea and we should find a better way but for now it's ok.
thanks