Skip to content

[4.3] Fix build tools Media Manager up merge#39597

Merged
HLeithner merged 1 commit intojoomla:4.3-devfrom
dgrammatiko:4.3-dev-build-tools-mm
Jan 12, 2023
Merged

[4.3] Fix build tools Media Manager up merge#39597
HLeithner merged 1 commit intojoomla:4.3-devfrom
dgrammatiko:4.3-dev-build-tools-mm

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

  • when up merged from 4.2 one line was wrongly left there (my bad)
  • Couple of changes, inline the source map (dev) + watch defaults to dev mode

Testing Instructions

Run npm ci, build:com_media:dev build:com_media and watch:com_media and confirm that the media manager is working

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@obuisard please consider merging this one before the next alpha, thanks

@dgrammatiko dgrammatiko force-pushed the 4.3-dev-build-tools-mm branch from fbf5d34 to dd3251e Compare January 11, 2023 11:59
@obuisard
Copy link
Copy Markdown
Contributor

Thanks Dimitris @dgrammatiko. I will test it later today. It will definitely be included in upcoming alpha 3.

@obuisard
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on dd3251e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39597.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on dd3251e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39597.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 12, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39597.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@HLeithner HLeithner merged commit 63e4f83 into joomla:4.3-dev Jan 12, 2023
@HLeithner
Copy link
Copy Markdown
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@dgrammatiko dgrammatiko deleted the 4.3-dev-build-tools-mm branch January 12, 2023 16:15
@Quy Quy added this to the Joomla! 4.3.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants