Converted read more alert to joomla-alert#39573
Merged
roland-d merged 3 commits intojoomla:4.2-devfrom Jan 12, 2023
Merged
Conversation
richard67
reviewed
Jan 8, 2023
build/media_source/com_content/js/admin-article-readmore.es6.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Contributor
|
I have tested this item ✅ successfully on c5c2f9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39573. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on c5c2f9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39573. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39573. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38991.
Summary of Changes
Converted read more alert to joomla-alert (not sure if this should be a warning instead of error).
Testing Instructions
Actual result BEFORE applying this Pull Request
Message displayed in js alert with broken ellipses
Expected result AFTER applying this Pull Request
Message displayed within Joomla's message system correctly
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed