[4.2] PHP8.2 deprecated dynamic properties#39503
Merged
HLeithner merged 1 commit intojoomla:4.2-devfrom Jan 12, 2023
Merged
Conversation
HelperFactoryAwareTrait
Member
|
This is ok like that. Was probably a copy paste error at that time. |
Member
|
I have tested this item ✅ successfully on 986bdb3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39503. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 986bdb3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39503. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39503. |
Member
|
thanks |
Contributor
|
Presumably this didn't get into 4.2.7? Still seems to be a problem on 4.3.1. I'm seeing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
https://www.php.net/manual/en/migration82.deprecated.php#migration82.deprecated.core.dynamic-properties
Testing Instructions
Open frontend where
mod_articles_latestand/ormod_articles_newsare displayedActual result BEFORE applying this Pull Request
PHP Deprecated: Creation of dynamic property
Joomla\Module\ArticlesLatest\Site\Dispatcher\Dispatcher::$helperis deprecated inlibraries/src/Helper/HelperFactoryAwareTrait.phpon line 61PHP Deprecated: Creation of dynamic property
Joomla\Module\ArticlesNews\Site\Dispatcher\Dispatcher::$helperis deprecated inlibraries/src/Helper/HelperFactoryAwareTrait.phpon line 61Expected result AFTER applying this Pull Request
No deprecated message
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
ping @laoneo who introduced helper factory aware interface in #37445
I'm not sure if this the "right" fix for b/c, also the variable names of the interface and trait do not match:
joomla-cms/libraries/src/Helper/HelperFactoryAwareInterface.php
Line 32 in e9b9263
joomla-cms/libraries/src/Helper/HelperFactoryAwareTrait.php
Line 59 in e9b9263