[4.2] PHP8.2 deprecated dynamic properties#39502
Merged
HLeithner merged 2 commits intojoomla:4.2-devfrom Jan 12, 2023
Merged
Conversation
wilsonge
approved these changes
Dec 26, 2022
Member
|
I have tested this item ✅ successfully on c7038ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39502. |
Member
|
The CalendarField has the same issue. |
Member
|
I have tested this item ✅ successfully on 7975d0c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39502. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39502. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
https://www.php.net/manual/en/migration82.deprecated.php#migration82.deprecated.core.dynamic-properties
Add
headerproperty to magic__getand__setmethodsTesting Instructions
Open category edit view with workflows enabled (com_categories/category/edit)
Actual result BEFORE applying this Pull Request
PHP Deprecated: Creation of dynamic property
Joomla\CMS\Form\Field\SqlField::$headeris deprecated inlibraries/src/Form/FormField.phpon line 591Expected result AFTER applying this Pull Request
No deprecated message
Link to documentations
Please select: