Skip to content

[4.2] PHP8.2 deprecated dynamic properties#39501

Merged
HLeithner merged 1 commit intojoomla:4.2-devfrom
heelc29:4.2/php82/dynamic-properties/plugin-adapter
Jan 12, 2023
Merged

[4.2] PHP8.2 deprecated dynamic properties#39501
HLeithner merged 1 commit intojoomla:4.2-devfrom
heelc29:4.2/php82/dynamic-properties/plugin-adapter

Conversation

@heelc29
Copy link
Copy Markdown
Contributor

@heelc29 heelc29 commented Dec 26, 2022

Summary of Changes

The creation of dynamic properties is deprecated

https://www.php.net/manual/en/migration82.deprecated.php#migration82.deprecated.core.dynamic-properties

Testing Instructions

Install a extension of type plugin

Actual result BEFORE applying this Pull Request

PHP Deprecated: Creation of dynamic property Joomla\CMS\Installer\Adapter\PluginAdapter::$group is deprecated in libraries/src/Installer/Adapter/PluginAdapter.php on line 373

Expected result AFTER applying this Pull Request

No deprecated message

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Jan 3, 2023
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jan 11, 2023

I have tested this item ✅ successfully on af0222a

Code review as it is obvious that this variable doesn't exist


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39501.

@joomdonation
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on af0222a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39501.

@joomla-cms-bot joomla-cms-bot removed PHP 8.x PHP 8.x deprecated issues PR-4.2-dev labels Jan 12, 2023
@joomdonation
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39501.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@Quy Quy added PHP 8 PHP 8.x PHP 8.x deprecated issues and removed PHP 8 labels Jan 12, 2023
@HLeithner HLeithner merged commit e91b797 into joomla:4.2-dev Jan 12, 2023
@HLeithner
Copy link
Copy Markdown
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@Quy Quy added this to the Joomla! 4.2.7 milestone Jan 13, 2023
@heelc29 heelc29 deleted the 4.2/php82/dynamic-properties/plugin-adapter branch January 15, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants