[4.2] fix admin module popular#39482
Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom Dec 28, 2022
Merged
Conversation
Member
|
I have tested this item ✅ successfully on 59956eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482. |
Contributor
|
I have tested this item ✅ successfully on 59956eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482. |
richard67
approved these changes
Dec 25, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add
created_byto list select query to get article items.The
created_byproperty is required if thecore.editpermission is not allowed. Function was added with #36559.joomla-cms/administrator/modules/mod_popular/src/Helper/PopularHelper.php
Lines 88 to 91 in e9b9263
Testing Instructions
Check the admin dashboard with a user with these permissions on com_content:
Actual result BEFORE applying this Pull Request
PHP Warning:
Undefined property: stdClass::$created_by in [ROOT]\administrator\modules\mod_popular\src\Helper\PopularHelper.php on line 90Expected result AFTER applying this Pull Request
Link to edit own article is displayed (and no PHP warning)
Link to documentations
Please select: