[4.2] Fix none empty string validation for MediaItem#39476
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Dec 28, 2022
Merged
[4.2] Fix none empty string validation for MediaItem#39476roland-d merged 2 commits intojoomla:4.2-devfrom
roland-d merged 2 commits intojoomla:4.2-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 1b4f3c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39476. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 1b4f3c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39476. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39476. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37242.
Summary of Changes
This simple PR fixes media manager broken when there is folder with name 0 (zero) managed by media manager.
Testing Instructions
Actual result BEFORE applying this Pull Request
You get error: Property 'name' of argument 'item' of event onFetchMediaItems has a wrong item. Valid: non empty string
Expected result AFTER applying this Pull Request
No error, media manager works properly
Link to documentations
Please select: