Skip to content

[4.2] Fix restore category from version history#39474

Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom
joomdonation:fix_restore_category_from_version_history
Dec 28, 2022
Merged

[4.2] Fix restore category from version history#39474
wilsonge merged 1 commit intojoomla:4.2-devfrom
joomdonation:fix_restore_category_from_version_history

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

Pull Request for Issue #39404.

Summary of Changes

This PR fixes 404 Component not found error when admin tries to restore a category from version history. See #39404 for detailed issue description.

Testing Instructions

  1. Use Joomla 4.2
  2. Go to Content -> Categories, click on a category to edit. Try to change the category data, save it so that versions history is stored for that category.
  3. On category edit screen, click on Versions button and try to restore the category to one of the saved version. You get 404 Component not found error
  4. Apply patch, confirm that the error is gone. The category is restored to the selected version.
  5. Try to restore an article from one of it's version history, confirm that it is still working OK

Actual result BEFORE applying this Pull Request

You get 404 Component not found error

Expected result AFTER applying this Pull Request

No error, category is successfully restored to the selected version.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 9a2a237


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39474.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 9a2a237


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39474.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Dec 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39474.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 22, 2022
@robbiejackson
Copy link
Copy Markdown

I've tested this and can confirm that this fixes the bug I originally raised. Thanks!

@wilsonge wilsonge merged commit a9849b5 into joomla:4.2-dev Dec 28, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 28, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.7 milestone Dec 28, 2022
@joomdonation joomdonation deleted the fix_restore_category_from_version_history branch December 29, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants