Fix $language default parameter#39434
Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom Dec 28, 2022
Merged
Conversation
Contributor
|
looks good to me but do you have a test instruction? Had you an error message or warning here? |
Contributor
Author
|
There is no error, it is just phpstan reporting this. |
Contributor
|
I have tested this item ✅ successfully on 73a9741 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434. |
Contributor
|
I have tested this item ✅ successfully on 73a9741 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39434. |
Contributor
|
Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the default value for the $language parameter. It makes it equal to
Joomla\CMS\Helper\RouteHelperfound inlibraries/src/Helper/RouteHelper.php.I am not sure if this is documented somewhere and that documentation would need to be updated.