Merged
Conversation
I was testing a script using the joomla repo and found these typos/grammar errors. The basic english language rule is that if you want to write "a something" and the "something" begins with a vowel then it changes to "an" This also applies even if the "something" _sounds_ like it begins with a vowel. As these are all corrections in comments testing is just by review
Contributor
|
I have tested this item ✅ successfully on 52d7ce0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39432. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 52d7ce0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39432. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39432. |
Contributor
|
Thank you |
Member
|
@roland-d I know it’s only grammar in comments, but have you seen my review comment? |
Contributor
Author
?? |
Contributor
|
@richard67 I only see that you merged |
Member
|
Ah i see the review was pending. |
richard67
reviewed
Dec 17, 2022
Member
|
Can you see it now? Review was pending still, my mistake. |
Contributor
|
Now it is visible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing a script using the joomla repo and found these typos/grammar errors.
The basic english language rule is that if you want to write "a something" and the "something" begins with a vowel then it changes to "an"
This also applies even if the "something" sounds like it begins with a vowel.
As these are all corrections in comments testing is just by review