Skip to content

com_finder FIX not translated Groups in content map filter#39359

Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom
cyrez:patch-52
Dec 19, 2022
Merged

com_finder FIX not translated Groups in content map filter#39359
fancyFranci merged 2 commits intojoomla:4.2-devfrom
cyrez:patch-52

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented Dec 5, 2022

Pull Request for Issue reported here: #39353 (comment)

Summary of Changes

  • Use branchSingular for select optgroup labels in admin filter Content Map.

Testing Instructions

  • Use another language than en-GB.
  • After Patch applied, optgroup labels are translated in your language.

Actual result BEFORE applying this Pull Request

Admin language used: de-DE

before

Expected result AFTER applying this Pull Request

Admin language used: de-DE

after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented Dec 5, 2022

@Kostelano This PR fixes the issue you reported in content map filter ;-)

@Kostelano
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 56c6638

Thanks, it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 56c6638


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 6, 2022
@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 56c6638

After having set it to RTC, I have tested again to make sure it was no mistake.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39359.

@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented Dec 6, 2022

Thank you @Kostelano @viocassel for testing!

After having set it to RTC, I have tested again to make sure it was no mistake.

Thank you @richard67 👍

@fancyFranci fancyFranci merged commit 8bbc625 into joomla:4.2-dev Dec 19, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 19, 2022
@fancyFranci fancyFranci added this to the Joomla! 4.2.7 milestone Dec 19, 2022
@fancyFranci
Copy link
Copy Markdown
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants