Skip to content

Fix contact category association#39358

Merged
roland-d merged 3 commits intojoomla:4.2-devfrom
joomdonation:fix_contact_category_association
Dec 17, 2022
Merged

Fix contact category association#39358
roland-d merged 3 commits intojoomla:4.2-devfrom
joomdonation:fix_contact_category_association

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

Fixes #39346.

Summary of Changes

This PR fixes wrong link generated by Language Switcher module for contact category association. Please look at #39346 to understand the issue.

Testing Instructions

  1. Setup a sample multilingual website using Joomla 4.2
  2. Follow the instructions at Associations not working for com_contact in Language Switcher module #39346 , confirm the issue.
  3. Apply patch, confirm the issue fixed.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

…ociationHelper.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 534b67e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.

@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Dec 5, 2022
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 534b67e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.

@richard67 richard67 removed the Maintainers Checked Used if the PR is conceptional useful label Dec 5, 2022
@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39358.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 5, 2022
@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Dec 5, 2022
@robbiejackson
Copy link
Copy Markdown

I couldn't find a Test This button, but I confirm that this fixes the issue 39346 I raised, and works well too as a solution for 3rd party components. In the case of the Joomla MVC tutorial all that the override of the getCategoryRoute method did here was add in the &lang= parameter into the query.

Just as an incidental query, is there a particular reason why this CategoryAssociationHelper class is marked as abstract?

@joomdonation
Copy link
Copy Markdown
Contributor Author

Just as an incidental query, is there a particular reason why this CategoryAssociationHelper class is marked as abstract?

I guess it is defined like that to prevent us from instantiate object of that class. It only contains one static method, so there is no reason to create object of that class (I'm unsure if that's the right reason).

@roland-d roland-d merged commit c2971fb into joomla:4.2-dev Dec 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 17, 2022
@roland-d
Copy link
Copy Markdown
Contributor

Thank you.

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Dec 17, 2022
@joomdonation joomdonation deleted the fix_contact_category_association branch December 18, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Associations not working for com_contact in Language Switcher module

7 participants