[4.2] Fix breadcrumb for Tagged Items menu item type#39331
Merged
roland-d merged 3 commits intojoomla:4.2-devfrom Jan 19, 2023
Merged
[4.2] Fix breadcrumb for Tagged Items menu item type#39331roland-d merged 3 commits intojoomla:4.2-devfrom
roland-d merged 3 commits intojoomla:4.2-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 4fe5e47 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39331. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 4fe5e47 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39331. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39331. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #27866.
Summary of Changes
Currently, when you view a menu item which is linked to Tagged Items menu item type, the browser page title (or titles of the selected tags) in the menu item parameter will be added as the last item in breadcrumb. That's not expected behavior, the breadcrumb should end with title of that menu item only. See #27866 for the long discussion about this.
Testing Instructions
Actual result BEFORE applying this Pull Request
Check the breadcrumb. The browser page title (or titles of the selected tags) in the menu item parameter will be added as the last item in breadcrumb.
Expected result AFTER applying this Pull Request
Check the breadcrumb. The browser page title (or titles of the selected tags) in the menu item parameter is not added as the last item in breadcrumb. The last item in breadcrumb is title of the menu item