[4.3] Mark deprecation in DelegatingPsrLogger#39224
Merged
HLeithner merged 1 commit intojoomla:4.3-devfrom Nov 22, 2022
nikosdion:architecture/j43-psrlogger-prep
Merged
[4.3] Mark deprecation in DelegatingPsrLogger#39224HLeithner merged 1 commit intojoomla:4.3-devfrom nikosdion:architecture/j43-psrlogger-prep
HLeithner merged 1 commit intojoomla:4.3-devfrom
nikosdion:architecture/j43-psrlogger-prep
Conversation
Contributor
|
I'm probably being overly pedantic here but isn't this better off as a note rather than deprecated. Because people will still be able to init the class and it's not deprecated (in the short term anyhow) for that purpose? |
Contributor
Author
|
The idea is that if someone does In the PR for 5.0 the deprecation is removed. The class is made final and the |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #39134 (comment)
Summary of Changes
\Joomla\CMS\Log\DelegatingPsrLoggerwas marked@internaland a deprecation notice information developers it will be marked final has been added.Testing Instructions
None. This PR only changes the DocBlock.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: PR 61