Skip to content

[4.2] Batch process categories -reverse ordering error#39174

Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom
heelc29:patch-39133
Dec 28, 2022
Merged

[4.2] Batch process categories -reverse ordering error#39174
wilsonge merged 1 commit intojoomla:4.2-devfrom
heelc29:patch-39133

Conversation

@heelc29
Copy link
Copy Markdown
Contributor

@heelc29 heelc29 commented Nov 7, 2022

Pull Request for Issue #39133 .

Summary of Changes

execute clear query first, before run new database operation in foreach-loop

Testing Instructions

see #39133

Actual result BEFORE applying this Pull Request

Reverse ordering is performed only for the first category
image

Expected result AFTER applying this Pull Request

Reverse ordering is performed for all selected categories
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 82900e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39174.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Dec 22, 2022

I have tested this item ✅ successfully on 82900e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39174.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Dec 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39174.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 22, 2022
@wilsonge wilsonge merged commit d294e3f into joomla:4.2-dev Dec 28, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 28, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.7 milestone Dec 28, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants