[4.2] Template Preview modal#39142
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Dec 18, 2022
Merged
Conversation
It is possible that the template->name does not match the template->element When that is the case then it is not possible to open the larger preview image of the template as the id of the modal is not the same as the id referenced in the button. This PR corrects that by using template->element in both places. To test The easiest way will be to create a child of cassiopeia and then edit the database. in #__extensions find the record for the child template and change the name only. Now in the admin template manager you will find that you get a js error when you try to open the larger preview image. Apply this PR and you will find that the preview opens correctly
Contributor
|
I have tested this item ✅ successfully on 55f6c52 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39142. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 55f6c52 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39142. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39142. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that the template->name does not match the template->element
When that is the case then it is not possible to open the larger preview image of the template as the id of the modal is not the same as the id referenced in the button.
This PR corrects that by using template->element in both places.
To test
The easiest way will be to create a child of cassiopeia and then edit the database.
in #__extensions find the record for the child template and change the name only.
Now in the admin template manager you will find that you get a js error when you try to open the larger preview image.
Apply this PR and you will find that the preview opens correctly
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed