Stats collection must not be shown in captive MFA pages#38533
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Aug 20, 2022
nikosdion:fix/38476-mfa-stats
Merged
Stats collection must not be shown in captive MFA pages#38533roland-d merged 2 commits intojoomla:4.2-devfrom nikosdion:fix/38476-mfa-stats
roland-d merged 2 commits intojoomla:4.2-devfrom
nikosdion:fix/38476-mfa-stats
Conversation
|
I have tested this item ✅ successfully on 2da7737 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533. |
Contributor
|
I have tested this item ✅ successfully on 2da7737 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533. |
Member
|
I have tested this item ✅ successfully on 2da7737 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38476 .
Summary of Changes
The
Joomla\CMS\Application\MultiFactorAuthenticationHandler::isMultiFactorAuthenticationPagemethod is now public and has an optional argument to only consider captive pages.The
plg_system_statsplugin uses this method to check whether it is running a captive MFA page and refuse to continue.A previously hard-coded exception for the stats plugin has been removed from the
MultiFactorAuthenticationHandlerTrait.Testing Instructions
Actual result BEFORE applying this Pull Request
You see the stats collection interface in the captive MFA page. Trying to use its buttons leads to a broken display experience as per the issue #38476.
Expected result AFTER applying this Pull Request
You do NOT see the stats collection interface in the captive MFA page or any of the captive pages you are allowed access to (basically, selecting an MFA method). It does appear after completing the MFA validation.
Documentation Changes Required
Plugins which render user interfaces in the backend of the site must check whether they are running under the Multi-factor Authentication feature's captive pages using the following code:
If this returns true the plugin MUST NOT render its user interface.