[4.2] Remove hotkeys.js by script.php#38523
Merged
roland-d merged 3 commits intojoomla:4.2-devfrom Aug 18, 2022
Merged
Conversation
Member
@fancyFranci That should not be the case. But the old folder and files may still be there on sites updated from pervious versions, and that's what will be deleted on update with your change. |
richard67
reviewed
Aug 18, 2022
richard67
reviewed
Aug 18, 2022
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
While the development of 4.2 hotkeys.js was renamed to hotkeysjs to avoid issues. Currently both
are in the buildmay be on sites, but the one with the dot should be removed with all its files and folders.@richard67 please have a look