Skip to content

[4.2] fix module name#38521

Merged
roland-d merged 1 commit intojoomla:4.2-devfrom
heelc29:issue-moduser-manifest
Aug 31, 2022
Merged

[4.2] fix module name#38521
roland-d merged 1 commit intojoomla:4.2-devfrom
heelc29:issue-moduser-manifest

Conversation

@heelc29
Copy link
Copy Markdown
Contributor

@heelc29 heelc29 commented Aug 18, 2022

Summary of Changes

module name in manifest don't match with module name

Testing Instructions

code review

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 1c83543


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38521.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Aug 18, 2022

I have tested this item ✅ successfully on 1c83543

Code review. I've verified that "mod_status" doesn't appear anywhere else beside the place fixed by this PR and the update SQL scripts and script.php where we delete the old module with that name and its files and folder.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38521.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38521.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@roland-d roland-d merged commit c9331a8 into joomla:4.2-dev Aug 31, 2022
@roland-d
Copy link
Copy Markdown
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 31, 2022
@roland-d roland-d added this to the Joomla! 4.2.2 milestone Aug 31, 2022
@heelc29 heelc29 deleted the issue-moduser-manifest branch September 1, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants