[4.2] Fix issue "updateCheck is null"#38519
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Aug 18, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 65394e0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519. |
Member
|
I have tested this item ✅ successfully on 65394e0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519. |
Member
|
RTC ! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38519. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38513.
Summary of Changes
Going to the joomla updater can lead to a js error because an optional element can not be found. This PR checks the element before it is used.
Testing Instructions
Short: Follow the instructions in the linked issue.
Long:
Open the developer tools of your browser to see the console.
Go to System -> Global Configuration -> Joomla! Update.
Try out different channels.
Everytime you click "Save & Close" you are redirected to the update page.
There you can click buttons like "Reinstall Joomla! core files"
Actual result BEFORE applying this Pull Request
An js error saying "TypeError: updateCheck is null" appears in the browser console. Depending on your debug settings it could say "a is null" or something like this. Buttons are not working.
Expected result AFTER applying this Pull Request
There is no js error and buttons should work as always.
Documentation Changes Required
Nope.