Conversation
Removes the empty folder libraries/vendor/symfony/string/Resources/bin from the distributed release.
|
I have tested this item ✅ successfully on 5d962b2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516. |
1 similar comment
|
I have tested this item ✅ successfully on 5d962b2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516. |
|
@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites. |
@zero-24 As far as I remember we once have decided that we don't leave the deleted files and folders in script.php up to the PR authors in J4 but we (maintainers, mostly me) do it for them. |
|
Thats why I didnt do it But to make life easier I just did it |
|
@richard67 ps you probably need to add hotkeys.js as a folder to remove as it was present in beta releases but is now renamed as hotkeysjs |
Ok didnt know about this change can you do a PR against the checklist so its not forgotten when other people are doing the releases? |
@brianteeman Thanks, will keep that in mind. |
|
I have tested this item ✅ successfully on 32f4961 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516. |
|
I have tested this item ✅ successfully on 32f4961 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516. |
|
Thank you! One more step for a better release |
Removes the empty folder libraries/vendor/symfony/string/Resources/bin from the distributed release.
Pull Request for Issue #38515
Test by code review and by checking that the folder doesnt exist in the pre-built package for this pr