Skip to content

[4.2] Empty folder#38516

Merged
fancyFranci merged 5 commits intojoomla:4.2-devfrom
brianteeman:build
Aug 18, 2022
Merged

[4.2] Empty folder#38516
fancyFranci merged 5 commits intojoomla:4.2-devfrom
brianteeman:build

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Removes the empty folder libraries/vendor/symfony/string/Resources/bin from the distributed release.

Pull Request for Issue #38515

Test by code review and by checking that the folder doesnt exist in the pre-built package for this pr

Removes the empty folder libraries/vendor/symfony/string/Resources/bin from the distributed release.
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zero-24 zero-24 added this to the Joomla 4.2.1 milestone Aug 18, 2022
@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Aug 18, 2022

I have tested this item ✅ successfully on 5d962b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.

1 similar comment
@ReLater
Copy link
Copy Markdown
Contributor

ReLater commented Aug 18, 2022

I have tested this item ✅ successfully on 5d962b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Aug 18, 2022

@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites.

@richard67
Copy link
Copy Markdown
Member

@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites.

@zero-24 As far as I remember we once have decided that we don't leave the deleted files and folders in script.php up to the PR authors in J4 but we (maintainers, mostly me) do it for them.

@brianteeman
Copy link
Copy Markdown
Contributor Author

Thats why I didnt do it

But to make life easier I just did it

@brianteeman
Copy link
Copy Markdown
Contributor Author

@richard67 ps you probably need to add hotkeys.js as a folder to remove as it was present in beta releases but is now renamed as hotkeysjs

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Aug 18, 2022

@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites.

@zero-24 As far as I remember we once have decided that we don't leave the deleted files and folders in script.php up to the PR authors in J4 but we (maintainers, mostly me) do it for them.

Ok didnt know about this change can you do a PR against the checklist so its not forgotten when other people are doing the releases?

@richard67
Copy link
Copy Markdown
Member

@richard67 ps you probably need to add hotkeys.js as a folder to remove as it was present in beta releases but is now renamed as hotkeysjs

@brianteeman Thanks, will keep that in mind.

@ReLater
Copy link
Copy Markdown
Contributor

ReLater commented Aug 18, 2022

I have tested this item ✅ successfully on 32f4961


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.

@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Aug 18, 2022
@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 32f4961

Checked the packages built by drone for this PR and checked that updating works with the update package and the changed script.php.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.

@richard67 richard67 removed the Maintainers Checked Used if the PR is conceptional useful label Aug 18, 2022
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.2.1 milestone Aug 18, 2022
@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@fancyFranci fancyFranci merged commit ec2009e into joomla:4.2-dev Aug 18, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@fancyFranci
Copy link
Copy Markdown
Contributor

Thank you! One more step for a better release

@fancyFranci fancyFranci added this to the Joomla 4.2.1 milestone Aug 18, 2022
@brianteeman brianteeman deleted the build branch August 18, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants