Make sure the itemID is of type int#38504
Conversation
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
|
Third attempt at fixing the same problem :( |
|
@brianteeman What did I do wrong? |
|
tested succesfully This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504. |
|
I have tested this item ✅ successfully on 8e29b77 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504. |
|
@roland-d I have tried the patch wihout issue BUT I could not reproduce the problem in the first place |
|
@obuisard Make sure you have correctly setup your multi-lingual site. Check that all plugins related to multi-lingual are enabled. If the multi-lingual check fails, the error will not be seen. |
|
tested succesfully |
Yes, all seems good, all plugins are enabled, and the site works as expected. |
@cappuccinonet Please mark your test result in the issue tracker so it is properly counted. For doing this, go to https://issues.joomla.org/tracker/joomla-cms/38504 , click the blue "Test this" button at the top left corner, select your test e and submit. Thanks in advance. |
Hello @cappuccinonet, please report your test in the issue tracker to report it. Thank you! Your help is appreciated. Sorry, I was not fast enough lol |
|
I have tested this item ✅ successfully on 8e29b77 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504. |
|
@roland-d I set did set the tag to PR-4.3-dev. Please change if this is not correct! |
|
I have tested this item ✅ successfully on 8e29b77 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504. |
|
@paternax There where already 2 successful tests so this PR was set to RTC. Please make sure that you only test PR's which have none or one successful test. every extra test is a wast of time and has no effect. Thanks anyway for taking the time to test! |
@RickR2H As you should be able to see, the base branch of this PR is 4,.2-dev, and so it needs the PR-4.2-dev label. It should also be easy to see on GitHub which labels were removed by the issue tracker when setting RTC, and so you should add back only these. |
|
Thx |
Pull Request for Issue #38489.
Summary of Changes
When you have a login menu item and use that on a multi-lingual site, logging in will end in failure
Argument must be of the type intTesting Instructions
Actual result BEFORE applying this Pull Request
Fatal error on login on multi-language site
Expected result AFTER applying this Pull Request
User is logged in
Documentation Changes Required
None