[4.2] remove php open close tags#38495
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Aug 18, 2022
Merged
Conversation
code review This is a redo of joomla#38484
Member
|
For some reason this PR doesn't appear in the issue tracker so I can't mark a test result. |
Member
|
Now it appears but has no "Test this" button. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38495. |
tecpromotion
approved these changes
Aug 17, 2022
richard67
approved these changes
Aug 17, 2022
Member
|
For some reason the issue tracker doesn't show this PR as a PR, i.e. it looks like an issue there, and there is no "Test this" button and no way to set RTC. Setting the RTC label here since this PR has 2 good code reviews. I have observed in past that the issue tracker sometimes has problems when several PRs are created at the same time or in a very short time period. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code review
This is a redo of #38484