Skip to content

[4.2] s/validatng/validating#38494

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
brianteeman:phil2
Aug 18, 2022
Merged

[4.2] s/validatng/validating#38494
roland-d merged 4 commits intojoomla:4.2-devfrom
brianteeman:phil2

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Typo code review

this is a redo of #38482

@richard67
Copy link
Copy Markdown
Member

For some reason the issue tracker doesn't show this PR as a PR, i.e. it looks like an issue there, and there is no "Test this" button and no way to set RTC.

Setting the RTC label here since this PR has 2 good code reviews.

@richard67 richard67 added RTC This Pull Request is Ready To Commit PR-4.2-dev labels Aug 17, 2022
@richard67
Copy link
Copy Markdown
Member

As I have observed in past, the issue tracker sometimes has problems when several PRs are created at the same time or in a very short time period.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 17, 2022
@richard67 richard67 added the RTC This Pull Request is Ready To Commit label Aug 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 17, 2022
@richard67 richard67 added the RTC This Pull Request is Ready To Commit label Aug 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 18, 2022
@roland-d roland-d merged commit 1107a88 into joomla:4.2-dev Aug 18, 2022
@roland-d
Copy link
Copy Markdown
Contributor

Thank you

@roland-d roland-d added this to the Joomla 4.2.1 milestone Aug 18, 2022
@brianteeman brianteeman deleted the phil2 branch August 18, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants