Skip to content

[4.3] Convert content contact plugin to services#38446

Merged
obuisard merged 8 commits intojoomla:4.3-devfrom
Digital-Peak:plugins/content/contact
Nov 10, 2022
Merged

[4.3] Convert content contact plugin to services#38446
obuisard merged 8 commits intojoomla:4.3-devfrom
Digital-Peak:plugins/content/contact

Conversation

@laoneo
Copy link
Copy Markdown
Member

@laoneo laoneo commented Aug 12, 2022

Summary of Changes

Converts the content contact plugin to services.

Testing Instructions

  • Enable the plugin
  • Set link to contact in the article options to yes in the article tab
  • Create a contact with assigned to the current logged in user
  • Create an article and set featured to yes
  • Open the article on the front

Actual result BEFORE applying this Pull Request

The "Written by" information links to the contact.

Expected result AFTER applying this Pull Request

The "Written by" information links to the contact.

@MacJoom
Copy link
Copy Markdown
Contributor

MacJoom commented Oct 31, 2022

I have tested this item ✅ successfully on 356b6fb

Tested successfully on 4.3-dev - no difference


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38446.

@heelc29
Copy link
Copy Markdown
Contributor

heelc29 commented Nov 6, 2022

I have tested this item ✅ successfully on 356b6fb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38446.

@laoneo
Copy link
Copy Markdown
Member Author

laoneo commented Nov 9, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38446.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 9, 2022
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Nov 10, 2022
@obuisard obuisard merged commit bba5bd4 into joomla:4.3-dev Nov 10, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 10, 2022
@obuisard
Copy link
Copy Markdown
Contributor

Thank you again for the PR Allon @laoneo

@laoneo laoneo deleted the plugins/content/contact branch November 10, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants