OpenSearch fix for: passing null is deprecated#38431
Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom Aug 31, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on c3636c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38431. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on c3636c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38431. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38431. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38427 .
Summary of Changes
Fix PHP 8 deprecation warning: Passing null to parameter ($string) of type string is deprecated
Testing Instructions
Use php 8+, error_reporting maximum
Apply patch.
Open smart search page. Add
?format=opensearchto URL, and open.Inspect the result.
Actual result BEFORE applying this Pull Request
deprecation warning
Expected result AFTER applying this Pull Request
no deprecation warning
Documentation Changes Required
no