[4.3] Deprecate Joomla\CMS\Schema\ChangeItem\SqlsrvChangeItem for 5.0#38428
Merged
sdwjoomla merged 2 commits intojoomla:4.3-devfrom Aug 13, 2022
Merged
Conversation
|
I have tested this item ✅ successfully on deae51d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38428. |
wilsonge
approved these changes
Aug 9, 2022
Contributor
|
I have tested this item ✅ successfully on deae51d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38428. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38428. |
Contributor
|
Thanks |
Member
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for #38405 (review) .
Summary of Changes
Deprecate the SqlsrvChangeItem class which was used by the database checker in Joomla 3 for checking the schema on MS SQL Server databases and which will be removed in Joomla 5 with PR #38405 .
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
The SqlsrvChangeItem class which is already useless in J4 is not marked as deprecated.
Expected result AFTER applying this Pull Request
The SqlsrvChangeItem class which is already useless in J4 is marked as deprecated.
Documentation Changes Required
None. It is already documented that Joomla 4 does not support running with a MS SQL Server database.