Skip to content

[4][com_finder] error when gather statistic enabled#38373

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
alikon:patch-8
Aug 17, 2022
Merged

[4][com_finder] error when gather statistic enabled#38373
roland-d merged 4 commits intojoomla:4.2-devfrom
alikon:patch-8

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Aug 2, 2022

Pull Request for Issue #38370 .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@alikon alikon mentioned this pull request Aug 2, 2022
Closed
@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Aug 2, 2022

Yes, it works for my error too.

@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Aug 2, 2022

Will the PR be marked as ready? Or are you looking for another way to solve the problem?

@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Aug 2, 2022

i really would like to hear from the thumbs down superstar, maybe he/she/it could explain what's wrong here and maybe give us a proper fix
anyway i'm digressing
that's my quick & dirty fix,
if you don't like it @SharkyKZ please propose yours

@alikon alikon marked this pull request as ready for review August 2, 2022 16:51
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 2, 2022

You are removing the sanitization on the query

@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Aug 8, 2022

I have tested this item ✅ successfully on eb8aa81

I'm posting a successful test as it works. Even if at the moment there is no better solution.

This needs to be fixed, otherwise users using the "Gather Search Statistics" option will be pleasantly surprised. I don't know how a release blocker is defined, but it looks like it.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38373.

@WeibelMarc WeibelMarc mentioned this pull request Aug 16, 2022
Closed
@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Aug 16, 2022

It is strange that they did not pay attention to this. In addition to @WeibelMarc's appeal, there is another one on the Russian-language forum.

roland-d
roland-d suggested changes Aug 17, 2022
View reviewed changes
@Kostelano
Copy link
Copy Markdown
Contributor

Kostelano commented Aug 17, 2022

I have tested this item ✅ successfully on 11fbfbd

After the changes everything works.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38373.

@bayareajenn
Copy link
Copy Markdown

bayareajenn commented Aug 17, 2022

I have tested this item ✅ successfully on 11fbfbd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38373.

@roland-d roland-d merged commit 4fa4101 into joomla:4.2-dev Aug 17, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Aug 17, 2022

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.1 milestone Aug 17, 2022
@alikon alikon deleted the patch-8 branch August 18, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@roland-d roland-d roland-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 4.2.1

Development

Successfully merging this pull request may close these issues.

7 participants

@alikon @Kostelano @brianteeman @bayareajenn @roland-d @rdeutz @joomla-cms-bot