Allow tabbing through the media manager grid#38141
Merged
HLeithner merged 1 commit intojoomla:4.2-devfrom Jun 27, 2022
Merged
Conversation
16ef9ea to
6aad873
Compare
This was referenced Jun 26, 2022
Member
|
@wilsonge When I have navigated to an action item and then have left it with escape, the image is selected, i.e. the selector checkbox is selected, and it stays like that when I navigate to the next image and so on. Is that one of the known glitches with the selector checkbox which you want to fix with a later PR? |
Contributor
Author
|
Yeah it's part of future selector improvements. Plus it's no different to how it works now (you just can see it now) |
Member
|
I have tested this item ✅ successfully on 6aad873 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141. |
Contributor
|
I have tested this item ✅ successfully on 6aad873 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial Pull Request for Issue #37117
Summary of Changes
Improve focussing on elements within the grid of media manager
Testing Instructions
Actual result BEFORE applying this Pull Request
You can tab through the grid elements but have no visible feedback on the toggle items (although you can enter them by hitting enter).
Expected result AFTER applying this Pull Request
Tab through the media manager elements - going over items now allows you to press enter to replace double clicking on them (in terms of opening folders or opening an image to a larger view). You also select the checkbox (it's not selectable still as part of this PR) and can open the action items view. You can leave the actions view from any item by hitting escape
Documentation Changes Required
N/A