Skip to content

[4.3] Replace Factory::getUser() by $this->getCurrentUser() in components models#38090

Merged
laoneo merged 7 commits intojoomla:4.3-devfrom
joomdonation:replace_getuser_in_components_models
Aug 12, 2022
Merged

[4.3] Replace Factory::getUser() by $this->getCurrentUser() in components models#38090
laoneo merged 7 commits intojoomla:4.3-devfrom
joomdonation:replace_getuser_in_components_models

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

@joomdonation joomdonation commented Jun 19, 2022

Pull Request for Issue # .

Summary of Changes

With #37498 being merged into 4.2, we can now replace deprecated method Factory::getUser() in components model classes with new method $this->getCurrentUser()

Testing Instructions

  1. Use Joomla 4.2 nightly build
  2. Apply patch
  3. Access to random pages (frontend, backend), make sure nothing is broken.

Actual result BEFORE applying this Pull Request

Works, but uses deprecated methods.

Expected result AFTER applying this Pull Request

Works, without using deprecated methods.

@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label Jun 20, 2022
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jun 20, 2022

I'm wondering if we should fallback here to Factory::getUser instead of an empty user?

@joomdonation
Copy link
Copy Markdown
Contributor Author

joomdonation commented Jun 20, 2022

Factory::getUser would be more safe, I think (I believe in site, administrator and api applications, the fallback is not needed). I just don't know how it is used in installation and console apps.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jun 20, 2022

Do you want to do it here or a separate one?

@joomdonation
Copy link
Copy Markdown
Contributor Author

joomdonation commented Jun 20, 2022

Better in the separate PR, please

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jun 20, 2022

Here we go #38106.

@joomdonation joomdonation mentioned this pull request Jun 25, 2022
Closed
@joomla-bot
Copy link
Copy Markdown
Contributor

joomla-bot commented Jun 27, 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jul 1, 2022

Would be good to postpone this for 4.3. What do you think @joomdonation?

@joomdonation
Copy link
Copy Markdown
Contributor Author

joomdonation commented Jul 1, 2022

@laoneo Yes, no rush. Let's give maintainers more time to review to see if there is any flow with this change.

@laoneo laoneo changed the base branch from 4.2-dev to 4.3-dev July 3, 2022 13:36
@laoneo laoneo changed the title [4.2] Replace Factory::getUser() by $this->getCurrentUser() in components models [4.3] Replace Factory::getUser() by $this->getCurrentUser() in components models Jul 3, 2022
@laoneo laoneo removed the PR-4.2-dev label Jul 3, 2022
@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Jul 28, 2022 •
edited
Loading

I have tested this item ✅ successfully on c19a04a

Tested good on frontend and backend pages in Joomla 4.3 dev

Drone is erroring out but looks like a timeout issue so I do not believe this related.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38090.

@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Jul 29, 2022

I have tested this item ✅ successfully on c19a04a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38090.

@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Jul 29, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38090.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 29, 2022
@laoneo laoneo merged commit 4eaafed into joomla:4.3-dev Aug 12, 2022
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Aug 12, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 12, 2022
@zero-24 zero-24 added this to the Joomla! 4.3.0 milestone Aug 13, 2022
@joomdonation joomdonation deleted the replace_getuser_in_components_models branch March 10, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laoneo laoneo laoneo approved these changes

Assignees

No one assigned

Labels

Maintainers Checked Used if the PR is conceptional useful

Projects

None yet

Milestone

Joomla! 4.3.0

Development

Successfully merging this pull request may close these issues.

7 participants

@joomdonation @laoneo @joomla-bot @jwaisner @RickR2H @zero-24 @joomla-cms-bot