Skip to content

Fix deprecated warning in taskModel#37977

Merged
bembelimen merged 1 commit intojoomla:4.1-devfrom
chmst:com-scheduler-task-deprecated
Jun 5, 2022
Merged

Fix deprecated warning in taskModel#37977
bembelimen merged 1 commit intojoomla:4.1-devfrom
chmst:com-scheduler-task-deprecated

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Jun 4, 2022

Pull Request for Issue # .

Summary of Changes

Fix deprecated warning in php 8.1.5
Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in administrator\components\com_scheduler\src\Model\TaskModel.php on line 324 (and 325).

Testing Instructions

Go to system / task scheduler. Add a new task, select one of the sample tasks and see the form with warning.
grafik

Actual result BEFORE applying this Pull Request

Deprecated Warning

Expected result AFTER applying this Pull Request

No Warning.

Documentation Changes Required

@chmst chmst added the PHP 8.x PHP 8.x deprecated issues label Jun 4, 2022
@richard67 richard67 changed the title Fix deprecated waring in taskModel Fix deprecated warning in taskModel Jun 4, 2022
@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Jun 4, 2022
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jun 5, 2022

I have tested this item ✅ successfully on 792eb32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37977.

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 792eb32

Finally found the time for a real test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37977.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37977.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@bembelimen bembelimen merged commit 71bd121 into joomla:4.1-dev Jun 5, 2022
@bembelimen
Copy link
Copy Markdown
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@bembelimen bembelimen added this to the Joomla 4.1.5 milestone Jun 5, 2022
@chmst chmst deleted the com-scheduler-task-deprecated branch December 13, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants