[4.1] PHP 8.1 Fix deprecated parse_str() passing null, in Menu ItemModel#37944
Merged
laoneo merged 2 commits intojoomla:4.1-devfrom Jun 3, 2022
Merged
[4.1] PHP 8.1 Fix deprecated parse_str() passing null, in Menu ItemModel#37944laoneo merged 2 commits intojoomla:4.1-devfrom
laoneo merged 2 commits intojoomla:4.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on e0ca9df This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37944. |
Contributor
|
I have tested this item ✅ successfully on e0ca9df This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37944. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37944. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix deprecated parse_str() passing null, in Menu ItemModel
Testing Instructions
Need PHP 8.1.
Apply patch.
Make sure error_reaporting set to maximum.
Go to menu, and try to create Menu type URL
Actual result BEFORE applying this Pull Request
PHP message about Deprecated parse_str() passing null
Expected result AFTER applying this Pull Request
No message
Documentation Changes Required
no