[4.2] Fix uninitialized version variable in installer library#37941
Merged
roland-d merged 3 commits intojoomla:4.2-devfrom Jun 1, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 4b0ee24 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37941. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 4b0ee24 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37941. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37941. |
Contributor
|
Thanks everybody |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37934 .
Summary of Changes
Move the log of the version number on schema updates to below the code where the version number is set.
Testing Instructions
See issue #37934 .
But code review should be sufficient.
See also my comment in the issue why it is only a 4.2-dev issue and ok in 4.1-dev: #37934 (comment)
Actual result BEFORE applying this Pull Request
No installer error.
Expected result AFTER applying this Pull Request
PHP warning about uninitialized variable $version being used at line 1334 of file libraries/src/Installer/Installer.php.
Documentation Changes Required
None.