com_fields - Fix deprecated warning in group model#37932
Merged
bembelimen merged 3 commits intojoomla:4.1-devfrom Jun 5, 2022
Merged
com_fields - Fix deprecated warning in group model#37932bembelimen merged 3 commits intojoomla:4.1-devfrom
bembelimen merged 3 commits intojoomla:4.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on c94011d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932. |
alikon
suggested changes
Jun 1, 2022
Contributor
Author
|
@toivo could you please re-test? |
Contributor
|
I have tested this item ✅ successfully on df2a42d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on df2a42d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37932. |
richard67
approved these changes
Jun 5, 2022
Contributor
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fix warning
Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in administrator\components\com_fields\src\Model\GroupModel.php on line 323
Testing Instructions
Add a new field group in com_contacts (php 8.1.5)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No deprecated warning
Documentation Changes Required