Conversation
|
Great. Personally other than the final wcag question these should be asked on all issues |
Totally agree. If/when this is merged I might open a new PR for the main issue template(s) to add some of those questions. |
|
One thing I'm not sure about - is it possible to set up the cms bot to add the a11y tag automatically to issues created with this template? |
|
Yes it is possible but sorry I don't know how to do that |
Except the question about assistive technologies, this will be unanswered in nearly all issues |
@zero-24 can you help here? |
I'm not aware of any that we can use right now. I could think of an "[A11Y]" tag in the title which could assign the label but hat has to be thought out what would make sense here as this can go wild fast. Maybe there is a way that is supported by github? |
|
This appears to be possible and it's also apparently possible to make it (and the others) an actual form with fields which might help all of the different issue templates: I'm going to do some digging. Would you all be open to revising the other templates too if this turns out to be easier? I could make a master pull request for all at once. |
|
go for it when you get a few minutes. always better when we use github core features over doing something with our bots and api stuff. l |
|
Couple of things I just remembered.
|
|
Brian, can you elaborate especially on point 2? |
|
Although I have never used it myself people commented that they didnt like that you had to complete all the fields and it prevented using other reporting tools which interact directly with github. (maybe thats fixed now I dont know) but below is an example report that is generated directly from Accessibility Insights for Web and posted into github which people saaid was not possible to use when you have these fields etc. Issue
Target applicationJoomla Content Management System (CMS) - try it! It's free! Element pathfooter > a[title="Free hosted Joomla! website"][href$="launch.joomla.org"] Snippet
How to fixEnvironmentChrome version 101.0.0.0 |
|
The GitHub docs say that you can mark fields as required or not required, but I'm not sure about integration with automated reporting tools that open new issues. |
Per the GitHub docs, it's possible to add the appropriate label automatically in the YAML front matter: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/manually-creating-a-single-issue-template-for-your-repository
|
I found a way to add the label automatically in the YAML frontmatter in the standard template per GH docs. To get this done faster, I just added it here. We can table the conversation about issue forms for another time, perhaps when it's out of beta. |
|
I too don't like issue forms on github. A template is a great help, but a form is a corset ;) I think this can be merged and other templates can be adapted, but don't mix it. |
I'm guessing thats a direct translation from german? Never heard that expression in english before but it is perfect |
|
Are there any other changes at this point or can it be merged? :) not sure who has the access to do that otherwise I'd tag the appropriate people. |
|
Thanks! |
Summary of Changes
Per the Joomla Accessibility Team meeting on May 24, it would be helpful to have an a11y-specific template when opening a Github issue for Joomla CMS. That way we can include specific questions and more easily identify and mitigate a11y issues.