How do build scripts now work e.g. index references here https://github.com/joomla/joomla-cms/blob/staging/build/build.php#L86

Plus I guess we can remove this script here https://github.com/joomla/joomla-cms/blob/staging/build/indexmaker.php

I'm wondering if we should provide a way for the user to generate these files in case their host doesn't support another way to prevent this sort of directory browsing. In which case - Ian's script might be useful there.

The build script "tags" files in each top level folder to ensure they're always in the packages. The index.html files were used because they were constant, and some of the top level folders don't have files within them, just more folders.

I hate to ask but are we gonna need to add each of these files into the script.php :(

btw, heads-up: git doesn't store at all completely empty folders, as it stores only files, so with this PR folders with only index.html will disappear ;-) .

I hate to ask but are we gonna need to add each of these files into the script.php :(

I wouldn't worry about it, if they're present on existing sites then so be it.

btw, heads-up: git doesn't store at all completely empty folders, as it stores only files, so with this PR folders with only index.html will disappear ;-) .

Examples (Override and Cache Folder in Backend and Frontend):
https://github.com/joomla/joomla-cms/tree/staging/administrator/cache
https://github.com/joomla/joomla-cms/tree/staging/administrator/language/overrides
https://github.com/joomla/joomla-cms/tree/staging/cache
https://github.com/joomla/joomla-cms/tree/staging/language/overrides

also tmp folder:
https://github.com/joomla/joomla-cms/tree/staging/tmp

and also /logs

Could we make this simple? index.html stays in empty folders and everything else gets removed. I created a PR against @drmmr763 s repo to do that. Lets get this approved. 😄

Merged in @Hackwar's changes, fixed the silly com_config change that shouldn't have been there.

@beat good catch! :)

Okay, just tested and all index.html are gone, except for cache/index.php and administrator/cache/index.php, but this is expected...

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3788.

umm shouldn't logs/index.html exist as well?

You are right...

What if we place a .gitignore file inside those empty folders (that might give the additional benefit of git-ignoring the contents)?

Oh, and a BIG 👍 for doing this 😉

We should have a 'hands-off' policy on all 3rd party as discussed on the chat. So if we have those in Tiny do they have a valid function or can we do that different?

No, we should not have a hands-off policy for 3rd party libraries, because there is no reason to ship the complete documentation of phpmailer for example with Joomla. If people need that documentation, they can look at it at the phpmailer dev site. There is no reason for us to add a Megabyte of static docs to our repository from a third party. I would remove the index.html files in codemirror, too, because they, too, are simply documentation for a developer when they want to implement this feature in their system and thus unnecessary for a normal enduser. But I honestly couldn't care less about those files. leave them in if you want.

Regarding the TinyMCE index.html files: WE added those files into TinyMCE according to our rule at that time that all folders should have such an index.html. They are not originaly from TinyMCE, they are not necessary for the functioning of TinyMCE and they are completely useless otherwise as well.

I partly agree but as Roland mentioned, they will be back in codemirror
or wherever as soon as an upgrade arrives. Understand me right please I
am all in favor to get rid of all those files as long as we do not break
things
On 11/23/2014 6:06 PM, Hannes Papenberg wrote:

No, we should not have a hands-off policy for 3rd party libraries,
because there is no reason to ship the complete documentation of
phpmailer for example with Joomla. If people need that documentation,
they can look at it at the phpmailer dev site. There is no reason for
us to add a Megabyte of static docs to our repository from a third
party. I would remove the index.html files in codemirror, too, because
they, too, are simply documentation for a developer when they want to
implement this feature in their system and thus unnecessary for a
normal enduser. But I honestly couldn't care less about those files.
leave them in if you want.

Regarding the TinyMCE index.html files: WE added those files into
TinyMCE according to our rule at that time that all folders should
have such an index.html. They are not originaly from TinyMCE, they are
not necessary for the functioning of TinyMCE and they are completely
useless otherwise as well.

—
Reply to this email directly or view it on GitHub
#3788 (comment).

As well as the documentation for phpmailer would be back if we copied it verbatim from the source. The job of the next guy updating codemirror would be to remove those again before commiting it to our repo. But since its simply useless bits and bytes that we are lugging around, its totally irrelevant if we have it or don't have it or if it gets added back in later on. Right now its identical to driving a rock around in your trunk. Doesn't hurt. Doesn't help either.

It costs bandwidth so it does hurts as would in your example the
increase of weight takes more petrol so your remark is very valid "The
job of the next guy updating codemirror would be to remove those again
before committing it to our repo." So we could start by removing those
from this 3.4 release?
On 11/23/2014 6:18 PM, Hannes Papenberg wrote:

As well as the documentation for phpmailer would be back if we copied
it verbatim from the source. The job of the next guy updating
codemirror would be to remove those again before commiting it to our
repo. But since its simply useless bits and bytes that we are lugging
around, its totally irrelevant if we have it or don't have it or if it
gets added back in later on. Right now its identical to driving a rock
around in your trunk. Doesn't hurt. Doesn't help either.

—
Reply to this email directly or view it on GitHub
#3788 (comment).

Hannes does make a valid point, that the documentation can be looked up at the website of the 3rd party plugin. As long a removing documentation from a 3rd party plugin doesn't interfere with it's workings I am fine with it. I mean, if there is a help button inside the editor that breaks because we remove the index.html file, one can wonder if we should remove it.

This should indeed be the responsibility of the maintainer but I don't know if we have set maintainers or it is just someone seeing it needs an update and creates a PR. This person may not be aware of what has been done in the past. We should document this somewhere.

For the libraries we pull in using composer, we added the doc and testing files to our .gitignore. See lines starting at https://github.com/joomla/joomla-cms/blob/staging/.gitignore#L46
This way we can pull in the whole library repo using composer, and only what we really need gets pushed into our own repo.
But this gets offtopic here a bit 😄

I find this actually very hard to review since GitHub doesn't show me the whole diff. There are 1283 changed files, but it only shows me the first 300. Thus I can't review it online. I have to download the diff into my IDE and see what it shows. PhpStorm calculates that since about 20 minutes, so I doubt that's gonna work well 😄

I wonder how you guys reviewed/tested that 😄

@Bakual Why don’t you apply this and just search in terminal for index.php? It sounds easier...

@DGT41 Don't tell me there is still a terminal in the year 2014. I prefer a GUI wherever I can use one.

GUI's are restrictive 😝

Command line interfaces expose the full toolset of whatever you're working with

/me steps off soapbox 😉

I used to think the same back in the days of DOS 😉

DOS 6.22 Those were the days… 😄

Pah -youngsters
On 23 Nov 2014 16:53, "Dimitris Grammatiko" notifications@github.com
wrote:

DOS 6.22 Those were the days… 😄

—
Reply to this email directly or view it on GitHub
#3788 (comment).

Did not we say that logs/index.html should stay?

Yes

I could be wrong but I reckon that 1283 is a few too many. By my count there should be 1239 deleted files. I arrived at this number by the following methodology so please let me know if it's wrong.

• checkout a new branch based on staging
• run the following shell commands to remove all index files then put them back in empty folders

find . -type f -name index.html | xargs rm
find . -type d -empty | xargs git checkout

• commit the changes then run diff --name-status against staging and count the lines

Since this PR is unfortunately not behaving like a good cheese and thus gets better with ageing, I'm thinking if it would be better to do this in batches instead. Like, removing all index.html from /components in one PR and then all from /modules in another. In the hopes that it can be reviewed by a CMS maintainer more easily...

I fully agree with Hannes. This PR can't easily reviewed due to the sheer amount of files.
GitHub only shows the first 300 changed files.

If someone wants to do smaller PRs with max 300 removed files, then I can review and merge them fast.

Make sure you don't remove index.html files from empty folders as that would remove the folder in Git as well.

I can do it soon.

here you go: #5377 #5378 #5378 #5379 #5380 #5381 #5382

@okonomiyaki3000 THANK YOU! 😄

@Hackwar No problem. It's really easy to do something like this if you use the command line, right @mbabker ?

@Bakual here is the PR to remove also the indexmaker script: #5383

Going to close this PR in favor of the smaller ones.
Thanks all!