Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 3fa7b26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 3fa7b26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877. |
Member
|
@brianteeman After I had updated your branch to make the npm step pass in drone, the scss code style check fails in drone: https://ci.joomla.org/joomla/joomla-cms/54621/1/24 . |
richard67
reviewed
May 26, 2022
build/media_source/templates/site/cassiopeia/scss/blocks/_tags.scss
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for fixing drone. I thought it might have been better as short hand but couldnt remember if we just left that to the compiler.. |
….scss Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Contributor
|
Thanks |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37864 .
Summary of Changes
add a margin around the tags so that the focus ring is displayed correctly
Testing Instructions
This is a css change so either use a pre-built package or npm run build:css
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
n/a