[4] com_content.article view. Remove redundant if $this->item->pagination#37861
Merged
Quy merged 2 commits intojoomla:4.1-devfrom May 28, 2022
ReLater:patch-2
Merged
[4] com_content.article view. Remove redundant if $this->item->pagination#37861Quy merged 2 commits intojoomla:4.1-devfrom ReLater:patch-2
if $this->item->pagination#37861Quy merged 2 commits intojoomla:4.1-devfrom
ReLater:patch-2
Conversation
Contributor
|
I have tested this item ✅ successfully on f2b8703 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37861. |
|
I have tested this item ✅ successfully on f2b8703 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37861. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37861. |
Contributor
|
I cannot find the code in may 4.1-dev branch. |
Member
@chmst Your link goes to line 138, but this PR changes line 95. The old commit changed line 43. |
Contributor
|
oops - thanks, this code needs more improvement ;) |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
!empty($this->item->pagination) && $this->item->paginationis redundant. "If it's not empty then it is" ;-)Testing Instructions