Improve PR #37772 - inlineHelp Toggle Button control#37849
Merged
laoneo merged 2 commits intojoomla:4.1-devfrom Jun 3, 2022
Merged
Improve PR #37772 - inlineHelp Toggle Button control#37849laoneo merged 2 commits intojoomla:4.1-devfrom
laoneo merged 2 commits intojoomla:4.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 12d9076 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849. |
Contributor
|
I approve of this change. Having been the one asking for it I am not sure if it's proper for me to provide a test? If so, let me know and I will. |
Contributor
|
I have tested this item ✅ successfully on 12d9076 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Pull Request #37819 for Issue #37772
Summary of Changes
Following @nikosdion comment #35610 (comment) and #35610 (comment)
This PR removes the ability to set an attribute inlineHelp to the form field xml element.
I agree with @nikosdion on his statement, and so i have improved and simplified here my previous PR to only focus on fixing issue with hidden descriptions if no inlinehelp toggle button integrated.
Testing Instructions
Same as for previous PR #37819