[5.0] New task plugin for check in items by rdeutz · Pull Request #37842 · joomla/joomla-cms

rdeutz · 2022-05-21T07:27:56Z

New feature

Thanks to @brianteeman for the idea.

Summary

New task plugin to check in all checked out items.

Testing Instructions

Apply patch
Check out some items
Create a new task in system/Scheduled Tasks
Select Global Checkin
Set Execution Rule to Manual Execution
Set a Title
Save
You should see something like this

Click on Run Task
Go Back to the checked out items, they should be checked in

You can also set a delay time in hours, then only items that are checkout before actual - delay time will be checked in.

Documentation Changes Required

Documentation needs to be updated

administrator/language/en-GB/plg_task_checkin.ini

administrator/language/en-GB/plg_task_checkin.sys.ini

plugins/task/checkin/checkin.php

plugins/task/checkin/checkin.xml

administrator/language/en-GB/plg_task_checkin.ini

plugins/task/checkin/checkin.php

plugins/task/checkin/checkin.xml

HLeithner · 2022-05-21T08:34:35Z

Nice plugin but blindly checking in all it's seems wrong to me. Can we get a parameter which allows us to configure an expire timeframe?

Something lime "Minutes to expire" default 60?

richard67 · 2022-05-21T09:22:59Z

Nice plugin but blindly checking in all it's seems wrong to me. Can we get a parameter which allows us to configure an expire timeframe?

Something lime "Minutes to expire" default 60?

I just wanted to say the same.

plugins/task/checkin/checkin.xml

brianteeman · 2022-05-21T14:33:57Z

Nice plugin but blindly checking in all it's seems wrong to me. Can we get a parameter which allows us to configure an expire timeframe?

Something lime "Minutes to expire" default 60?

I just wanted to say the same.

Except the core component does it blindly as well

laoneo · 2022-05-21T14:43:12Z

Can you please use the modern way with a service provider.

richard67 · 2022-05-21T15:48:00Z

Nice plugin but blindly checking in all it's seems wrong to me. Can we get a parameter which allows us to configure an expire timeframe?
Something lime "Minutes to expire" default 60?

I just wanted to say the same.

Except the core component does it blindly as well

The core component is change controlled by a human while a scheduler task runs unattended.

rdeutz · 2022-05-21T16:15:37Z

Changed so that you can set a delay time.

plugins/task/checkin/checkin.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Co-authored-by: Konstantin Kolos <k0nstantinkolos88@gmail.com>

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

rdeutz · 2022-05-22T13:14:34Z

needs a bit more time fighting with the service provider

Co-authored-by: Brian Teeman <brian@teeman.net>

richard67 · 2023-08-26T09:13:35Z

@rdeutz It needs to rename the update SQL scripts again because meanwhile we have some with a higher schema version (base name) in the repo so yours would not run on an update. I suggest to rename them to "5.0.0-2023-08-27.sql" because there are other PR's proposed which will already use "5.0.0-2023-08-22.sql" to "5.0.0-2023-08-26.sql".

rdeutz · 2023-08-26T09:21:51Z

@richard67 done, with a bit luck some tests today and we can merge this

richard67 · 2023-08-26T09:23:48Z

@richard67 done, with a bit luck some tests today and we can merge this

@rdeutz Thanks.

webgras · 2023-08-26T10:43:38Z

I have tested this item ✅ successfully on 6b3e80e

also check articles on two different times

tested on J 5.0.0-beta1-dev

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37842.}

plugins/task/globalcheckin/forms/globalcheckin_params.xml

plugins/task/globalcheckin/globalcheckin.xml

plugins/task/globalcheckin/src/Extension/Globalcheckin.php

alikon · 2023-08-26T11:21:59Z

I have tested this item ✅ successfully on 6b3e80e

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37842.}

alikon · 2023-08-26T11:27:57Z

some kind of cache issue
btw i'm fully confortable with this pr
waiting for the last mile
i'll redo my test

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

richard67 · 2023-08-26T12:55:33Z

@alikon @webgras Could you test again with the latest changes? Thanks in advance.

plugins/task/globalcheckin/src/Extension/Globalcheckin.php

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

heelc29 · 2023-08-26T13:46:36Z

I have tested this item ✅ successfully on 6b3e80e

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37842.}

webgras · 2023-08-26T13:51:32Z

I have tested this item ✅ successfully on 6b3e80e

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37842.}

HLeithner · 2023-08-26T13:52:08Z

finally thanks all

rdeutz · 2023-08-26T13:58:06Z

Thanks to all who helped to get this done

create a new example plugin

febf10d

joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels May 21, 2022

rdeutz changed the title ~~[4.2]Create a new example plugin~~ [4.2] New example task plugin for check in items May 21, 2022

brianteeman reviewed May 21, 2022

View reviewed changes

administrator/language/en-GB/plg_task_checkin.ini Outdated Show resolved Hide resolved

brianteeman reviewed May 21, 2022

View reviewed changes

administrator/language/en-GB/plg_task_checkin.sys.ini Outdated Show resolved Hide resolved

brianteeman reviewed May 21, 2022

View reviewed changes

plugins/task/checkin/checkin.php Outdated Show resolved Hide resolved

brianteeman reviewed May 21, 2022

View reviewed changes

plugins/task/checkin/checkin.php Outdated Show resolved Hide resolved

fixes based on comments

e3c9ec8

Kostelano reviewed May 21, 2022

View reviewed changes

plugins/task/checkin/checkin.xml Outdated Show resolved Hide resolved

heelc29 suggested changes May 21, 2022

View reviewed changes

administrator/language/en-GB/plg_task_checkin.ini Outdated Show resolved Hide resolved

plugins/task/checkin/checkin.php Outdated Show resolved Hide resolved

plugins/task/checkin/checkin.php Outdated Show resolved Hide resolved

plugins/task/checkin/checkin.xml Outdated Show resolved Hide resolved

Kostelano reviewed May 21, 2022

View reviewed changes

plugins/task/checkin/checkin.xml Outdated Show resolved Hide resolved

rdeutz added 2 commits May 21, 2022 18:02

updated to allow a delay time

1b600fb

Merge branch '4.2-dev' into new_task_example_checkin

4aa2349

richard67 reviewed May 21, 2022

View reviewed changes

plugins/task/checkin/checkin.php Outdated Show resolved Hide resolved

rdeutz and others added 6 commits May 22, 2022 14:25

Update plugins/task/checkin/checkin.php

d650801

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Update plugins/task/checkin/checkin.xml

95e4df9

Co-authored-by: Konstantin Kolos <k0nstantinkolos88@gmail.com>

Update plugins/task/checkin/checkin.xml

7f911a8

Co-authored-by: Konstantin Kolos <k0nstantinkolos88@gmail.com>

Update plugins/task/checkin/checkin.xml

28e1aab

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

Merge branch '4.2-dev' into new_task_example_checkin

992473c

refactoring

652b590

rdeutz marked this pull request as draft May 22, 2022 13:13

WIP

3581f25

HLeithner changed the title ~~New example task plugin for check in items~~ [5.0] New task plugin for check in items Jul 27, 2023

rdeutz and others added 3 commits August 26, 2023 11:02

Update plugins/task/globalcheckin/services/provider.php

21e49c1

Co-authored-by: Brian Teeman <brian@teeman.net>

Update administrator/language/en-GB/plg_task_globalcheckin.ini

b928bb9

Co-authored-by: Brian Teeman <brian@teeman.net>

Merge branch '5.0-dev' into new_task_example_checkin

aba1677

change files names of update scripts

dab9ad8

Merge branch '5.0-dev' into new_task_example_checkin

61ffc3e

heelc29 reviewed Aug 26, 2023

View reviewed changes

plugins/task/globalcheckin/forms/globalcheckin_params.xml Outdated Show resolved Hide resolved

plugins/task/globalcheckin/globalcheckin.xml Outdated Show resolved Hide resolved

heelc29 reviewed Aug 26, 2023

View reviewed changes

plugins/task/globalcheckin/src/Extension/Globalcheckin.php Outdated Show resolved Hide resolved

rdeutz and others added 4 commits August 26, 2023 14:35

Update plugins/task/globalcheckin/globalcheckin.xml

3d921b0

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

Update plugins/task/globalcheckin/forms/globalcheckin_params.xml

6a3446f

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

fix application

3bed206

use $db instead of application

4ca0fe2

heelc29 reviewed Aug 26, 2023

View reviewed changes

plugins/task/globalcheckin/src/Extension/Globalcheckin.php Outdated Show resolved Hide resolved

Update plugins/task/globalcheckin/src/Extension/Globalcheckin.php

f9bf1b6

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

HLeithner merged commit 0a5d604 into joomla:5.0-dev Aug 26, 2023

HLeithner added this to the Joomla! 5.0 milestone Aug 26, 2023

rdeutz deleted the new_task_example_checkin branch August 26, 2023 13:58

jgerman-bot mentioned this pull request Aug 27, 2023

[5.0] New task plugin for check in items joomlagerman/joomla#2918

Closed

joomlapl-bot mentioned this pull request Aug 27, 2023

[5.0] New task plugin for check in items JoomlaPolska/jezyk-J4#402

Closed

Uh oh!

Conversation

rdeutz commented May 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing Instructions

Documentation Changes Required

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HLeithner commented May 21, 2022

Uh oh!

richard67 commented May 21, 2022

Uh oh!

Uh oh!

brianteeman commented May 21, 2022

Uh oh!

laoneo commented May 21, 2022

Uh oh!

richard67 commented May 21, 2022

Uh oh!

rdeutz commented May 21, 2022

Uh oh!

Uh oh!

rdeutz commented May 22, 2022

Uh oh!

richard67 commented Aug 26, 2023

Uh oh!

rdeutz commented Aug 26, 2023

Uh oh!

richard67 commented Aug 26, 2023

Uh oh!

webgras commented Aug 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alikon commented Aug 26, 2023

Uh oh!

alikon commented Aug 26, 2023

Uh oh!

richard67 commented Aug 26, 2023

Uh oh!

Uh oh!

heelc29 commented Aug 26, 2023

Uh oh!

webgras commented Aug 26, 2023

Uh oh!

HLeithner commented Aug 26, 2023

Uh oh!

rdeutz commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

rdeutz commented May 21, 2022 •

edited

Loading