PSR12 transformation preparation by HLeithner · Pull Request #37681 · joomla/joomla-cms

HLeithner · 2022-04-27T19:56:38Z

Preparation Pull Request for Motion PROD2021/004: Update the code style to PSR12 as early as possible but latest for 5.0
This pull requests prepares the cms repository for that automated transformation PR #37686.

Motion:

Summary of Changes

Replace FinderHelperRoute import with namespaced version
Remove {} in switch statements
Removed a require statement which is unused since 2010
Remove another unnecessary require not used anymore
Deprecate JCOMPAT_UNICODE_PROPERTIES and moved the functionality into the function
Add phpcs exception for SideEffects in BufferStreamHandler which will be removed in 5.0 (planned for 4.0)

Testing Instructions

Most of the changes are CS changes and can be done by code review.
For FinderHelperRoute a simple test with smart search would be enough
JCOMPAT_UNICODE_PROPERTIES can't be tested without an "broken" pcre library so code review would be enough

Documentation Changes Required

Deprecation of JCOMPAT_UNICODE_PROPERTIES

brianteeman · 2022-04-27T20:06:57Z

could you please include the text of Motion PROD2021/004. so that this pr contains an explanation of the chaanges

HLeithner · 2022-04-27T20:14:08Z

The motion is really reduced to "Switch from custom codestyle to PSR-12" I added the motion description to the description.

libraries/src/Form/FormRule.php

build/psr12/.editorconfig

build/psr12/clean_errors.php

build/psr12/phpcs.joomla.report.php

build/psr12/psr12_converter.php

build/psr12/clean_errors.php

HLeithner · 2022-04-29T09:58:08Z

@brianteeman I hopefully added all your fixes into the last commit. I added by hand to not make the pr too complex. All thanks go to you

HLeithner · 2022-06-27T11:04:42Z

@brianteeman I added the PR converter script, it's not really testable for you but maybe you can check my english?

build/psr12/convert_pull_requests.php

brianteeman · 2022-06-27T11:10:18Z

build/psr12/convert_pull_requests.php

+        Joomla! PSR-12 Converter
+        =======================
+        Usage:
+            IMPORTANT THIS SCRIPT HAVE TO BE OUTSIDE OF THE REPOSITORY


Suggested change

IMPORTANT THIS SCRIPT HAVE TO BE OUTSIDE OF THE REPOSITORY

IMPORTANT THIS SCRIPT HAS TO BE OUTSIDE OF THE REPOSITORY

build/psr12/convert_pull_requests.php

brianteeman · 2022-06-27T11:19:18Z

@brianteeman I added the PR converter script, it's not really testable for you but maybe you can check my english?

first pass done

HLeithner · 2022-06-27T12:07:22Z

I updated all Text changes btw. I also changed the "dir=auto" in the phpcs template from your comment in the commit.

thanks

build/psr12/.editorconfig

HLeithner · 2022-06-27T13:19:53Z

thanks updated.
I plan to do the PSR-12 conversation today starting at 16:00 UTC as long as nothing comes in between.

@brianteeman

Thanks to @brianteeman

joomla-cms-bot added the PR-4.2-dev label Apr 27, 2022

HLeithner force-pushed the 4.2-psr12-preparation branch from 6190650 to eb69c10 Compare April 28, 2022 14:26

Quy reviewed Apr 28, 2022

View reviewed changes

libraries/src/Form/FormRule.php Outdated Show resolved Hide resolved

HLeithner mentioned this pull request Apr 28, 2022

[4.2] Change Codestyle to PSR-12 #37686

Merged

HLeithner force-pushed the 4.2-psr12-preparation branch from eb69c10 to 60ae76a Compare April 29, 2022 08:31