[4.2] Deprecate old resync function#37634
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Apr 27, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on dd68feb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37634. |
Contributor
|
Good to go lets just await the next alpha release as we where asked by the RLs. |
Member
Author
|
No pressure |
Contributor
|
Thanks everybody |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Deprecates the resync function in the menus controller as it was only used in 1.5. Was added over 12 years ago in 89b50c5.
Can be merged by review.
Testing Instructions
Nothing to test as it is not used in core anymore as far as I can see.