[4.2] (re) Introduce a body end renderer#37330
Closed
dgrammatiko wants to merge 12 commits intojoomla:4.2-devfrom
Closed
[4.2] (re) Introduce a body end renderer#37330dgrammatiko wants to merge 12 commits intojoomla:4.2-devfrom
dgrammatiko wants to merge 12 commits intojoomla:4.2-devfrom
Conversation
brianteeman
reviewed
Mar 20, 2022
Co-authored-by: Brian Teeman <brian@teeman.net>
575f532 to
51a1976
Compare
Contributor
Author
|
There's nothing in their docs: https://www.php.net/manual/en/function.serialize.php |
Contributor
Contributor
Author
|
@brianteeman @alikon that article is talking about implementing an own serialised/unserializer and that for 8.1 it needs both the old and the new functions. But I'm not using |
laoneo
reviewed
Mar 22, 2022
Quy
reviewed
Mar 22, 2022
Quy
reviewed
Mar 23, 2022
156c73a to
033677d
Compare
14f4689 to
d0ebd8b
Compare
Contributor
Author
|
@SharkyKZ why the thumbs down? |
Member
|
Why did you close? |
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request is the base for many Issues associated with modals. Fixes #37297
Summary of Changes
Testing Instructions
Backend Toolbars
Try to edit an article and check the source of the document (scroll to the end) [preferably with debug disabled]
Apply the PR
Check again the source, the last entries before < /body > should be some modals
Check that the toolbar buttons versions, preview and a11y checks are all functionals
Backend Multiple editors in different tabs #37297
Ensure the global editor is set to 'None'
Edit
administrator/components/com_content/forms/article.xmland addAfter line 264. Try to check if both editors have functional buttons
Apply the PR and repeat the test
Repeat the test for code mirror
Actual result BEFORE applying this Pull Request
Chunks of HTML can only be echoed sequentially, eg the toolbar modals are echoed immediately after the button
Expected result AFTER applying this Pull Request
Chunks of HTML can be enqueued to be echoed at the end of the document
Documentation Changes Required
@laoneo this is needed if you want to see any improvement on the modals
@roland-d in order to solve #37297 and a few more modal related issues this (or something similar) is required